Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fullscreen popups explainer and related doc #140

Merged
merged 14 commits into from
Aug 29, 2023

Conversation

bradtriebwasser
Copy link
Contributor

Adds an explainer for "Fullscreen popups" which proposes the ability to open new popups and transition them to HTML fullscreen via a single call to window.open().

Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lg, but take another read yourself to ensure this matches the latest discussions and documents.

EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
security_and_privacy_fullscreen_popups.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@bradtriebwasser bradtriebwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I missed an upstream commit which aligned the document with more of our recent discussion and changes. Please take another look!

Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor editorial suggestion, thanks!

EXPLAINER_fullscreen_popups.md Outdated Show resolved Hide resolved
Mention one popup per transient user activation more explicitly.
@michaelwasserman michaelwasserman merged commit b439243 into w3c:main Aug 29, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Aug 29, 2023
SHA: b439243
Reason: push, by michaelwasserman

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants