Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace window-placement permission references with window-management #115

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Replace window-placement permission references with window-management #115

merged 5 commits into from
Oct 31, 2022

Conversation

bradtriebwasser
Copy link
Contributor

@bradtriebwasser bradtriebwasser commented Oct 27, 2022 •
edited by pr-preview bot
Loading

Resolves the first step in Issue #114 to rename the permission string from window-placement to window-management.

Preview | Diff

michaelwasserman
michaelwasserman requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @anssiko and @reillyeon

CHANGES.md Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
anssiko
anssiko approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is both more descriptive and future-proof name.

I believe we want to add this string to https://w3c.github.io/permissions-registry/#registry-table-of-provisional-permissions

Here's an example on the logistics of it: https://github.com/w3c/permissions-registry/pull/16/files

michaelwasserman
michaelwasserman approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@michaelwasserman michaelwasserman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out that provisional permissions table step, Anssi!
lgtm with a nit for the CHANGES.md file.

CHANGES.md Outdated Show resolved Hide resolved
reillyeon
reillyeon approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a link to the Chromium issue for implementing of the rename for tracking purposes.

@bradtriebwasser bradtriebwasser merged commit d90a9b7 into w3c:main Oct 31, 2022
@bradtriebwasser bradtriebwasser mentioned this pull request Oct 31, 2022
Closed
github-actions bot added a commit that referenced this pull request Nov 1, 2022
@bradtriebwasser @github-actions
Replace window-placement permission references with `window-managem…
d2f2fe1 
…ent` (#115)

SHA: d90a9b7
Reason: push, by bradtriebwasser

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwasserman michaelwasserman michaelwasserman approved these changes

@anssiko anssiko anssiko approved these changes

@reillyeon reillyeon reillyeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradtriebwasser @reillyeon @anssiko @michaelwasserman