Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDL changes for setMetadata for 3.2.2 webrtc nv use case #202

Closed
wants to merge 13 commits into from
Closed

IDL changes for setMetadata for 3.2.2 webrtc nv use case #202

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
54b82fd
Update index.bs to include IDL changes for setMetadata
palak8669 Aug 3, 2023
05d28f7
Change dfn tag
palak8669 Aug 3, 2023
6120dce
Remove restriction on streams being limited to only one PC
palak8669 Aug 4, 2023
9eb6c9d
Update index.bs to only include metadata changes necessary for 3.2.2
palak8669 Sep 5, 2023
c932a82
Update index.bs to have consistent defintion for audio and video
palak8669 Sep 5, 2023
5727c4a
Update index.bs to include formatting changes
palak8669 Sep 5, 2023
918aeb8
Merge branch 'main' into setmetadata-pr
palak8669 Sep 29, 2023
a6cc530
Merge branch 'main' into setmetadata-pr
palak8669 Oct 6, 2023
1ed307e
Merge branch 'main' into setmetadata-pr
palak8669 Oct 11, 2023
bafe76c
Apply suggestions from code review
palak8669 Oct 11, 2023
88a559c
Update index.bs
palak8669 Oct 11, 2023
54bb9c2
Update index.bs
palak8669 Oct 11, 2023
0a86a80
Update index.bs
palak8669 Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ interface RTCEncodedVideoFrame {
readonly attribute RTCEncodedVideoFrameType type;
attribute ArrayBuffer data;
RTCEncodedVideoFrameMetadata getMetadata();
undefined setMetadata(optional RTCEncodedVideoFrameMetadata metadata = {});
};
</pre>

Expand Down Expand Up @@ -440,6 +441,16 @@ interface RTCEncodedVideoFrame {
Returns the metadata associated with the frame.
</p>
</dd>
<dt>
<dfn for="RTCEncodedVideoFrame" method>setMetadata()</dfn>
</dt>
<dd>
<p>
Sets a new metadata that would be associated with the frame. Only allowed to change the fields
frameId, dependencies and rtpTimetsamp in the RTCEncodedVideoFrameMetadata. All other changes
are not allowed and should return an error.
</p>
</dd>
</dl>

### Serialization ### {#RTCEncodedVideoFrame-serialization}
Expand Down Expand Up @@ -533,6 +544,7 @@ dictionary RTCEncodedAudioFrameMetadata {
interface RTCEncodedAudioFrame {
attribute ArrayBuffer data;
RTCEncodedAudioFrameMetadata getMetadata();
undefined setMetadata(optional RTCEncodedAudioFrameMetadata metadata = {});
};
</pre>

Expand All @@ -558,6 +570,16 @@ interface RTCEncodedAudioFrame {
Returns the metadata associated with the frame.
</p>
</dd>
<dt>
<dfn for="RTCEncodedAudioFrame" method>setMetadata()</dfn>
</dt>
<dd>
<p>
Sets a new metadata that would be associated with the frame. Only allowed to change
the rtpTimetsamp field in the RTCEncodedAudioFrameMetadata. All other changes are
not allowed and should return an error.
</p>
</dd>
</dl>


Expand Down
Loading