Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the conservative page loading strategy #1000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shs96c
Copy link
Contributor

@shs96c shs96c commented Aug 9, 2017

This waits for all resources of a page to have finished
loading, and not just for the readyState to reach
"complete".

Addresses #893.


This change is Reviewable

This waits for all resources of a page to have finished
loading, and not just for the readyState to reach
"complete".

Addresses w3c#893.
@shs96c shs96c added this to the Level 2 milestone Aug 9, 2017
@shs96c
Copy link
Contributor Author

shs96c commented Aug 9, 2017

Marking as an L2 fix. It's deemed to be a new feature, which is not in keeping with the CR period.

@jgraham
Copy link
Member

jgraham commented Nov 6, 2017

Per the testing policy, this PR can't be accepted without a corresponding test in the web-platform-tests reposiotry.

@andreastt
Copy link
Member

@shs96c Do you have time to also write the tests for this?

Because we don’t currently have any tests for the other page loading strategies it may be required to do those first, which could be a bit of work. @whimboo has written some excellent Marionette navigation tests that we would be happy to share with WPT, but we need to CC-0 license it first. @whimboo, would that be easy to do?

@whimboo
Copy link
Contributor

whimboo commented Jan 3, 2018

@whimboo has written some excellent Marionette navigation tests that we would be happy to share with WPT, but we need to CC-0 license it first. @whimboo, would that be easy to do?

I wrote those tests as employee of Mozilla, so you can automatically handle those as CC-0. The tests can be found here:

https://hg.mozilla.org/mozilla-central/file/default/testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py#l615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants