Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to locate nodes using computed accessibility attributes #660

Merged
merged 13 commits into from
Apr 18, 2024

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Feb 13, 2024

Based on: #624
Issue: #443


Preview | Diff

@OrKoN OrKoN changed the title Orkon/locator a11y Add an ability to locate nodes using computed accessibility attributes Feb 13, 2024
@OrKoN
Copy link
Contributor Author

OrKoN commented Feb 13, 2024

@sadym-chromium PTAL

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@OrKoN
Copy link
Contributor Author

OrKoN commented Feb 13, 2024

@jrandolf PTAL

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@OrKoN OrKoN requested a review from jgraham April 5, 2024 09:15
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Add an ability to locate nodes using computed accessibility attributes.

The full IRC log of that discussion <AutomatedTester_> topic: Add an ability to locate nodes using computed accessibility attributes
<AutomatedTester_> github: https://github.com//pull/660
<AutomatedTester_> orkon: this is a feature used in puppeteer and wanted to check if there are concerns?
<AutomatedTester_> jgraham1: I don;t think so, I think the approval just slipped through the cracks

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful for WebdriverIO not have to create weird xpath selectors that aren't 100% correct all the time

👍

@lutien
Copy link
Contributor

lutien commented Apr 11, 2024

@OrKoN, are you planning to add wpt tests for it, once the spec is merged?

@OrKoN
Copy link
Contributor Author

OrKoN commented Apr 11, 2024

@lutien yes

index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But note the small fixup required.

index.bs Outdated Show resolved Hide resolved
Co-authored-by: jgraham <[email protected]>
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as well now. Thanks.

@OrKoN OrKoN merged commit 88f2def into main Apr 18, 2024
5 checks passed
@OrKoN OrKoN deleted the orkon/locator-a11y branch April 18, 2024 10:51
github-actions bot added a commit that referenced this pull request Apr 18, 2024
#660)

SHA: 88f2def
Reason: push, by OrKoN

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants