Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extended proof chain test vectors #99

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Wind4Greg
Copy link
Contributor

@Wind4Greg Wind4Greg commented Oct 2, 2024

This PR fixes the extended proof chain test vectors to use all four public/private key pairs as documented in the specification text. The previous test vectors repeated the use of public/private key number 3 rather than using key number 4. Note: test vectors are informative.


Preview | Diff

Copy link

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the corrections and thanks for the PR.

@msporny msporny added editorial This item is editorial in nature. CR1 labels Oct 5, 2024
@msporny
Copy link
Member

msporny commented Oct 14, 2024

Editorial, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 5073ff1 into w3c:main Oct 14, 2024
2 checks passed
@Wind4Greg Wind4Greg deleted the chain-testvector-fix branch December 9, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 editorial This item is editorial in nature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants