-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added note clarifying that credentialSubject.id is not used #196
base: main
Are you sure you want to change the base?
Conversation
…p the entry in the status list.
@@ -733,6 +733,12 @@ <h3>BitstringStatusListEntry</h3> | |||
credential. | |||
</p> | |||
|
|||
<p class="note"> | |||
It is important to note that the statusListIndex is the only link between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some formatting fixes (I think) here and below.
It is important to note that the statusListIndex is the only link between | |
It is important to note that `statusListIndex` is the only link between |
@@ -733,6 +733,12 @@ <h3>BitstringStatusListEntry</h3> | |||
credential. | |||
</p> | |||
|
|||
<p class="note"> | |||
It is important to note that the statusListIndex is the only link between | |||
the [=Verifiable credential=] and its status in the list. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the [=Verifiable credential=] and its status in the list. The | |
the [=verifiable credential=] and its status in the list. The |
the [=Verifiable credential=] and its status in the list. The | ||
```credentialSubject.id``` is not used when checking status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting fixes (I think) and a slight tweak to make credentialSubject.id
just one example -- and to change the "when" conjunction so we aren't suggesting that some business rule can't consider other properties "during" a status check, but rather, those properties aren't used to check status, or more specifically for the purpose of VC status list linkage. I believe we are trying to say these other properties aren't the relevant "links" to status here, and this is the best language I could quickly come up with.
the [=Verifiable credential=] and its status in the list. The | |
```credentialSubject.id``` is not used when checking status. | |
the [=verifiable credential=] and its status in the list. Other | |
properties such as `credentialSubject.id` are not used for | |
this purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as @dlongley's changes are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Dave's changes are acted on +1 to approve this.
The issue was discussed in a meeting on 2025-01-08
View the transcript4.1. added note clarifying that credentialSubject.id is not used (pr vc-bitstring-status-list#196)See github pull request vc-bitstring-status-list#196. Brent Zundel: There is one request for changes from Dave Longley.
Kevin Dean: Just to say that Joe is unable to join today, power outage, high winds, etc. Brent Zundel: Yes, thoughts with Joe with the CA fires. Kevin Dean: He feels that the PR is simple enough to be worked on without his presence. Brent Zundel: Looks like Dave's changes are editorial for the most part. Manu Sporny: +1 to the PR as long as the changes go in, that's it. Brent Zundel: Any other comments? Our standard practice is to allow the PR author to accept changes so we shouldn't move forward with those things regardless of how editorial they may be. |
to look up the entry in the status list.
Addresses #184
Preview | Diff