Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logical/abstract values for touch-action #496

Draft
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Jan 21, 2024

Adds pan-inline, pan-inline-start, pan-inline-end, pan-block, pan-block-start, pan-block-end values for touch-action, and expands the explanation to reference https://www.w3.org/TR/css-writing-modes-3/

Closes #272


Preview | Diff

@patrickhlauke patrickhlauke added future needs-wpt Investigation whether the issue needs a wpt test has been done and wpt is missing labels Jan 21, 2024
@patrickhlauke
Copy link
Member Author

Discussed at last PEWG meeting (31 Jan). There's a few more tiny language tweaks I'd love to make, just to make it clear which element's writing mode needs to be taken into consideration (tl;dr: the element where the touch-action is defined, and not any of the child elements inside it). setting back to draft until I sorted that.

@patrickhlauke patrickhlauke marked this pull request as draft February 13, 2024 12:09
@smaug---- smaug---- removed the needs-wpt Investigation whether the issue needs a wpt test has been done and wpt is missing label May 24, 2024
@smaug----
Copy link
Contributor

Removing needs-wpt for now, since this isn't even in the spec. We definitely should add a wpt at the same time when landing this

@patrickhlauke
Copy link
Member Author

discussed in today's PEWG meeting. want to include a graph/chart

need to also clarify explicitly what happens if you have touch-action defined on an element, and then a child element defines a different writing mode/direction (in short, only the one on the element that defined touch-action counts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logical dimension values for touch-action property, since logical is/has shipped
2 participants