Use object for PermissionSetParameters.descriptor
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Feb 13, 2024
saschanaz
changed the title
object for PermissionSetParameters.descriptorobject for PermissionSetParameters.descriptor
marcoscaceres
approved these changes
Mar 8, 2024
miketaylr
approved these changes
Mar 8, 2024
|
Yes, this is fine, but we need to potentially update implementations to match the IDL change. |
Looks like it for Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/interfaces/permissions.idl;l=39?q=PermissionSetParameters Oh, but this is within automation, nevermind. |
|
Actually, as it's just part of the WebDriver part, I think it's ok to merge. @miketaylr, is that ok with you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also fixes rootDesc.name use. Failing to convert
descriptorwould throw at a later step but this shouldn't matter as all error types are same.closes #443
Preview | Diff