Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window-management to table of provisional permissions. #19

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Add window-management to table of provisional permissions. #19

merged 3 commits into from
Nov 2, 2022

Conversation

bradtriebwasser
Copy link
Contributor

@bradtriebwasser bradtriebwasser commented Nov 2, 2022

@bradtriebwasser
Copy link
Contributor Author

@marcoscaceres PTAL

@miketaylr miketaylr self-requested a review November 2, 2022 23:10
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR!

@@ -373,6 +373,29 @@ <h2>
NO
</td>
</tr>
<tr data-cite="window-placement">
<td class="string-token">
"[=window-management=]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the permission side of things https://github.com/w3c/window-placement/blob/main/index.bs#L732 looks good.

index.html Show resolved Hide resolved
@miketaylr miketaylr merged commit d7e4318 into w3c:main Nov 2, 2022
github-actions bot added a commit that referenced this pull request Nov 2, 2022
SHA: d7e4318
Reason: push, by miketaylr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants