Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define monitorTypeSurfaces #274

Merged
merged 12 commits into from
Aug 31, 2023
Merged

Define monitorTypeSurfaces #274

merged 12 commits into from
Aug 31, 2023

Conversation

eladalon1983
Copy link
Member

@eladalon1983 eladalon1983 commented Aug 25, 2023

Fixes #261.


Preview | Diff

@eladalon1983
Copy link
Member Author

CC @Coread

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 31, 2023
Spec PR: w3c/mediacapture-screen-share#274

WIP

Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 31, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling
getDisplayMedia(), wishes the user has the option to choose the display surfaces whose type is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: TODO

Bug: TODO
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
index.html Outdated
<p>
{{monitorTypeSurfaces}} is just a hint. The user agent may still offer to the user
the option to capture [=display surfaces=] of type [=display surface/monitor=].
Applications are therefore encouraged to still check the {{displaySurface}} setting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Applications are therefore encouraged to still check the {{displaySurface}} setting
Applications are therefore encouraged to still check the {{MediaTrackSettings/displaySurface}} setting

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 31, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling
getDisplayMedia(), wishes the user has the option to choose the display surfaces whose type is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: TODO
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: TODO
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
@eladalon1983 eladalon1983 merged commit 881fd35 into w3c:gh-pages Aug 31, 2023
1 check passed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 31, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: TODO
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: TODO
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: TODO
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: TODO
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 1, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 6, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
aarongable pushed a commit to chromium/chromium that referenced this pull request Sep 7, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 7, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 7, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 13, 2023
…monitorTypeSurfaces, a=testonly

Automatic update from web-platform-tests
Implement the DisplayMediaStreamOptions monitorTypeSurfaces

This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}

--

wpt-commits: 49d6aa17ff973bd570aec96f322b145b47977360
wpt-pr: 41742
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Sep 14, 2023
…monitorTypeSurfaces, a=testonly

Automatic update from web-platform-tests
Implement the DisplayMediaStreamOptions monitorTypeSurfaces

This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}

--

wpt-commits: 49d6aa17ff973bd570aec96f322b145b47977360
wpt-pr: 41742
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
This adds the ability for web applications to provide a hint, indicating
to the user agent whether the application, upon calling getDisplayMedia,
wishes the user has the option to choose the display surfaces whose type
is monitor (screen).

Spec PR: w3c/mediacapture-screen-share#274
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3kqlI58U8Q/m/EDnovcDgAAAJ

Spec: https://w3c.github.io/mediacapture-screen-share/#dom-displaymediastreamoptions-monitortypesurfaces
Demo: https://screen-sharing-controls.glitch.me/?monitorTypeSurfaces=exclude
Bug: 1477706
Change-Id: I25ffabe546ddc778f660834e44a9dab15494e92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831171
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1193498}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow apps to avoid riskier display-surface types
2 participants