Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous/asynchronous Promise rejection #28

Merged
merged 11 commits into from
Mar 24, 2022

Conversation

eladalon1983
Copy link
Member

@eladalon1983 eladalon1983 commented Mar 18, 2022

Fixes #14.


Preview | Diff

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@jan-ivar jan-ivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now since we have #29 to clean this up

@eladalon1983 eladalon1983 merged commit 6f6da4b into w3c:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cropTo is returning promises but it is unclear when promises are supposed to be rejected synchronously or not
3 participants