Clarify that frameRate as a setting is the configured value, not a measurement. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what we expect to see under ideal conditions, which may or may not be what we measure. |
youennf
approved these changes
Oct 12, 2022
Co-authored-by: youennf <[email protected]>
alvestrand
approved these changes
Oct 12, 2022
|
How is this different from #512? |
I don't think it's different, it's just a clarification. Not only does Chrome implement to "sometimes return a setting and sometime return a measurement" but it turns out this misunderstanding has even spread to more recent specs written after that clarification was added: So being explicit about it seems like a good thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906.
Preview | Diff