Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for @context redefinition. #591

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Add test for @context redefinition. #591

merged 3 commits into from
Mar 6, 2024

Conversation

davidlehn
Copy link
Contributor

See #590.

  • Please double check this is the correct error code.
  • The test naming is still confusing, I think erNN is ok?

@davidlehn davidlehn mentioned this pull request Feb 7, 2024
Closed
niklasl
niklasl reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@niklasl niklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (TRLD passes these two added tests.)

I just think the HTML versions of the manifests need to be regenerated.

@gkellogg
Copy link
Member

gkellogg commented Feb 7, 2024

Elsewhere, I've implemented GH actions that automatically update HTML manifests when input manifests change. I can do something like that here as well.

@BigBlueHat BigBlueHat mentioned this pull request Mar 6, 2024
Closed
dlongley
dlongley approved these changes Mar 6, 2024
View reviewed changes
tests/toRdf-manifest.jsonld Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member

gkellogg commented Mar 6, 2024

This PR was discussed in a meeting.

PR #591 ✪
#591 -> Pull Request 591 Add test for `@context` redefinition. (by davidlehn) [test:missing-coverage] ✪
Niklas Lindström: Looks good, we can merge. ✪

@gkellogg gkellogg merged commit 61f07cb into main Mar 6, 2024
3 checks passed
@gkellogg gkellogg deleted the add-context-term-test branch March 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@gkellogg gkellogg gkellogg approved these changes

@niklasl niklasl niklasl approved these changes

Assignees
No one assigned
Labels
test:missing-coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidlehn @gkellogg @niklasl @dlongley