Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the HRM #586

Open
wants to merge 1 commit into
base: issues/bump-imsc-1-3
Choose a base branch
from
Open

Conversation

palemieux
Copy link
Contributor

Closes #582

@palemieux palemieux changed the title Refactor HRM Refactor the HRM Dec 27, 2024
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as is, though I think more discussion is warranted, about maintaining the SHALL requirement, and if we should be giving any forward guidance to the industry about how we intend to decouple the specifications in the future.

Also §2. Introduction mentions the HRM:

To assist implementers in developing Processors that can render all Document Instances, § 11. Hypothetical Render Model specifies an hypothetical rendering model that is used to measure and limiting Document Instance complexity.

so that probably needs to change.

Comment on lines -2427 to -2429

<p class="note">As specified in [[ttml2]], <code>tts:overflow</code> has no effect on the extent of the region, and hence the
total normalized drawing area S(E<sub>n</sub>) at <a href='#paint-regions'></a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this note is not duplicated in IMSC-HRM. Worth opening an issue to add it somewhere, so the information is not lost?

<section>
<h4>Hypothetical Render Model</h4>

<p><a>Document Instance</a> SHALL conform to the Hypothetical Render Model specified at [[!imsc-hrm]].</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested to know why this is a SHALL: when we discussed it before, and my recollection is based on what is captured in the linked issue, the idea was to make the two Recommendations independent, so that it would be possible to conform to IMSC but not the HRM, for example.

I don't currently have a strong view, and doing it this way is the "minimal change", but I'd like us to consider the pros and cons, perhaps on a TTWG call.

Also, we should add a note here or in the changes section (or both) because although this appears to be a "no net normative change" edit, in fact it removes HRM conformance requirements for the image profile, since we removed image painting metrics from the IMSC-HRM spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants