Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-values] Use fetch 'conclude' instead of 'finalize' #7160

Merged
merged 2 commits into from
Mar 24, 2022
Merged

[css-values] Use fetch 'conclude' instead of 'finalize' #7160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e1eee
[css-values] Use fetch 'conclude' instead of 'finalize'
noamr Mar 20, 2022
1dda7b8
nit
noamr Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions css-values-4/Overview.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,12 +1037,12 @@ URL Processing Model</h4>
[=request/credentials mode=] is "same-origin", [=request/use-url-credentials flag=] is
set, and whose [=request/referrer=] is |referrer|.

10. [=/Fetch=] |req|, with <var ignore>taskDestination</var> set to |global|, and <var ignore>processResponseConsumeBody</var>
set to the following steps given [=/response=] |res| and Null, failure or byte stream
|byteStream|:
10. Let |controller| be the result of [=/Fetch|fetching=] |req|, with <var ignore>taskDestination</var>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make a change here, but just fyi, Bikeshed's conjugation support means you could just write [=/fetching=] and it'll link correctly to /fetch

set to |global|, and <var ignore>processResponseConsumeBody</var> set to the following steps given
[=/response=] |res| and Null, failure or byte stream |byteStream|:
1. If |sheet|'s <a spec=cssom>origin-clean flag</a> is set,
[=finalize and report timing=] with |res|, |global|, and
<code>"css"</code>. [[CSSOM]]
[=fetch-controller/conclude=] |controller|, with <var ignore>initiatorType</var> set
to <code>"css"</code>. [[CSSOM]]

2. Call |processResponse| with |res| and |byteStream|.

Expand Down