-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated SkipTo.js version to a version that supports "instant" scrolling #3141
Open
jongund
wants to merge
7
commits into
main
Choose a base branch
from
update/skipto5.6.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-montalvo
changed the title
updated SkipTo.js version to a version tat supports scrolling
updated SkipTo.js version to a version that supports scrolling
Oct 14, 2024
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: Skipto Update<jugglinmike> github: https://github.com//pull/3141 <jugglinmike> Matt_King: Jon made some changes to skipto and submitted them as a pull request <jugglinmike> Jon: I've been testing here at the University of Illinois. The feedback I received means that none of the changes will be perceptible to end users <jugglinmike> Jon: I added a new "scrollTo" feature which is off by default. I could enable that feature if you would like, but consensus here at the University of Illinois was to disable it <jugglinmike> Jon: besides that, there are changes under-the-hood related to web components <jugglinmike> Matt_King: The motion is in direct response to pressing a key, so don't we always expect some kind of change in that case? <jugglinmike> Matt_King: I always thought the motion thing was... Well, maybe the problem is the smooth-scrolling specifically <jugglinmike> Jon: I can enable the "instant scroll" variant of the feature and people can take a look at that <jugglinmike> Jon: I can also open a separate pull request with the "smooth scroll" variant of the feature. With two pull requests, people would be better-equipped to compare <dmontalvo> q+ Lola <jugglinmike> Matt_King: I think we should evaluate it within this group. There's even the possibility that you could add something to feature--somehow making it easy for people to update their setting directly <dmontalvo> q+ howard-e <jugglinmike> Jon: Let's let people try the two kinds of scrolling and test to make sure that it gets disabled when people turn off the feature on their OS <jugglinmike> Matt_King: Sounds good <jugglinmike> Lola: Is there a place for the user to control scrolling in the place where the scrolling is? <jugglinmike> Jon: there is not right now <jugglinmike> Lola: I think there would need to be if it were on by default. I believe WCAG requires that users have the ability to adjust animation whenever it is used <jugglinmike> Jon: scrolling only occurs when people use skipTo <jugglinmike> Matt_King: I don't know if this counts as animation. This is exactly the same kind of scrolling that you get with tabs <dmontalvo> ack Lola <jugglinmike> Jon: think the next step is for people to try it <jugglinmike> Jon: I'll make that second pull request <jugglinmike> ack howard-e <jugglinmike> howard-e: It sounds to me like the scroll is controlled in the script itself. Or is it in an HTML attribute? <jugglinmike> Jon: It can be controlled through a data- attribute, yet <jugglinmike> Jon: there are three states: none, smooth, and instant <jugglinmike> s/yet/yes/ |
jongund
changed the title
updated SkipTo.js version to a version that supports scrolling
updated SkipTo.js version to a version that supports "instant" scrolling
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of skipto supports scrolling, but it is off by default.
Feedback that I have received indicates people with motion distractions want an opt in, rather than default feature, So need to discuss at an upcoming meeting.
WAI Preview Link (Last built on Thu, 17 Oct 2024 00:08:33 GMT).