Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure script's settings and realm for service workers #1294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Mar 28, 2018

  1. Configure script's settings and realm for service workers

    Service workers have a different script execution model from other
    workers. Update algorithm fetches a service worker script, and Run
    Service Worker algorithm runs the script when installing it and whenever
    functional events and message events need to be dispatched.
    
    This change:
     - Passes null as the value of script settings object/module map
       settings object argument to fetch a classic worker script/fetch a
       module worker script graph algorithm, respectively, called in Update
       algorithm, instead of the placeholder argument "the to-be-created
       environment settings object".
     - Sets the script's settings to the environment settings object created
       in Run Service Worker algorithm and the script's record.[[Realm]] to
       that settings object's Realm.
    
    Fixes #1013.
    jungkees committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    d8e8e1c View commit details
    Browse the repository at this point in the history