Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some updates to encoder requirements #242

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make some updates to encoder requirements #242

wants to merge 3 commits into from
+61 −51

Conversation

garretrieger
Copy link
Contributor

@garretrieger garretrieger commented Nov 21, 2024 •
edited
Loading

Make some updates to encoder requirements based on the discussion in #240:

  1. Disallow fonts that have the same compat ID for both IFT and IFTX tables. Duplicate IDs creates ambiguities in handling invalidation modes.
  2. Add an additional normative encoder requirement that patches must respect the expected behaviour for declared invalidation modes.
  3. Clarify how to select between same intersection entries when same intersection entries exist in both mapping tables. This is resolved by only considering the entries from one table at a time.

Preview | Diff

@garretrieger
When grouping same intersection entries only consider entries from th…
5f8b5d1 
…e same patch map.

This resolves the ambiguity in selecting the first listed entry if there are entries from both mapping tables have the same intersection.
@garretrieger
Add an additional normative encoder requirement that patches match th…
71f3c5e 
…eir declared invalidation mode.
@garretrieger
Disallow IFT fonts that have two tables with the same compat ID.
a13549d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skef skef Awaiting requested review from skef

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garretrieger