-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to ISOBMFF #33
base: master
Are you sure you want to change the base?
Conversation
Fine with application/mp4. What is the added value in rephrasing the handler_type? It is already stated which box it is in. The ISOBMFF spec states where the the handler box is. Restating referenced spec language just raises maintenance issues. I would like Silvia's opinion about using code font for field names instead of the single quote style. If she agrees, then the entire spec should be changed. Agree with the ExtendedLanguage box, given the caveat of the font comment above. |
Regarding the rewrite of handler_type, there are 2 aspects:
Regarding the use of <code> that's how the HTML spec does it. So I thought it'd be better. I agree with waiting for Silvia. |
This section is about how a UA determines the type of a track, not whether the UA will actually create the track. In fact the suggested shall statements contradict your addition to the intro stating "If a UA exposes a track". The current wording is appropriate, except for the error about video being 'soun' and audio being "vide". That needs to be fixed. |
I filed a bug on the soun/video issue. Regarding style edits, this should be done across the whole document, not a piece at a time. This should also have discussion and is probably best proposed as a bug. |
fine, then cherry pick the 1st and 3rd comment for merge. |
<li>text track: the 'handler_type' value is "meta", "subt" or "text"</li> | ||
<li>video track: the 'handler_type' value is "soun"</li> | ||
<li>audio track: the 'handler_type' value is "vide"</li> | ||
<li>If the <code>handler_type</code> value is <code>meta</code>, <code>subt</code> or <code>text</code>, the user agent shall create a <code>TextTrack</code> object.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is much harder to read. I prefer we keep it the other way around.
@silviapfeiffer I understand. The idea was first to have the normative statement. I'll rewrite the PR to keep the readability but improve the normative part. |
This PR is related to bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=26929
It adds application/mp4 and rephrases the requirements about handler_type.