Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Abstract/Introduction/Purpose #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cwilso
Copy link
Collaborator

@cwilso cwilso commented Oct 4, 2024

Alternate fix to issue identified in #183 .


Preview | Diff

@cwilso cwilso requested review from tantek and fantasai October 4, 2024 20:21
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good compression of similar sentences and simplification of three sections down to two. I believe this change addresses the issue noted in PR #183 and if we merge this PR we can close 183 without prejudice.

@tantek tantek added the Project Vision Vision and Principles label Oct 4, 2024
Copy link
Contributor

@fantasai fantasai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I think this makes the text less coherent. We have a paragraph and a list that are both about the goals of this document, that were together as a whole, and now are split far apart. And appending the goals to the existing preamble doesn't flow together, it feels very tacked-on and alien to the rest of the section.

@tantek tantek requested review from wareid and mgendler October 4, 2024 23:20
@frivoal
Copy link
Contributor

frivoal commented Oct 4, 2024

Interesting attempt, but I don't think this works for me.

Moving the first paragraph of the "purpose" section to the abstract might be reasonable, but moving the list part to the intro feels off. If we were to move the list of goals somewhere else, in the extreme, I could see it move to STOD, since it's kind of commentary about the document and so arguably not part of the document itself, but moving it further into the document feels like the opposite of what we should do.

As it stands, I'd be happier with #183 or status quo.

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no consensus on this PR, and it is unnecessary for an updated Note, so I am labeling it "defer" without prejudice.

I still think this PR is a net improvement, though primarily stylistic, and something we can perhaps more effectively address in the context of feedback we expect from wide review, so I'm leaving it open for now and marking as "Request changes" as a reminder to incorporate any related wide review feedback accordingly.

@tantek tantek added the Defer Deferred to future work label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defer Deferred to future work Project Vision Vision and Principles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants