Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: move dfs order to CFGAnalysis #4330

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Oct 25, 2024

What I did

move dfs order calculation from domtree to cfg analysis.

remove unnecessary calculation of domtree in sccp

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review October 25, 2024 17:49
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 20 lines in your changes missing coverage. Please review.

Project coverage is 44.83%. Comparing base (658f0c4) to head (24f90a6).

Files with missing lines Patch % Lines
vyper/venom/analysis/cfg.py 30.43% 16 Missing ⚠️
vyper/venom/analysis/dominators.py 66.66% 3 Missing ⚠️
vyper/venom/passes/sccp/sccp.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (658f0c4) and HEAD (24f90a6). Click for more details.

HEAD has 137 uploads less than BASE
Flag BASE (658f0c4) HEAD (24f90a6)
139 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4330       +/-   ##
===========================================
- Coverage   91.34%   44.83%   -46.51%     
===========================================
  Files         112      112               
  Lines       15921    15935       +14     
  Branches     2691     2693        +2     
===========================================
- Hits        14543     7145     -7398     
- Misses        943     8182     +7239     
- Partials      435      608      +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant