ntp: T6911: fix migration script to not allow empty "service ntp" CLI node #4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
|
✅ No issues found in unused-imports check.. Please refer the workflow run |
jestabro
approved these changes
Jan 23, 2025
… node With T3008 we moved from ntpd to chrony. This came with a restructuring of the CLI (mainly moving ntp out of system to services). In addition the definition of a server was made mandatory. The bug itself manifests at a more crucial point - config migration vyos-router[1265]: Migration script error: /opt/vyatta/etc/config-migrate/migrate/ntp/1-to-2: [Errno 1] failed to run command: ['/opt/vyatta/etc/config-migrate/migrate/ntp/1-to-2', '/opt/vyatta/etc/config/config.boot'] vyos-router[1265]: returned: - op: copy old_path: ['system', 'ntp'] new_path: ['service', 'ntp'] vyos-router[1265]: - op: delete path: ['system', 'ntp'] The fix is that we will no longer migrate an empty ntp CLI node from the old syntax to the new.
|
CI integration ❌ failed! Details
|
dmbaturin
approved these changes
Jan 24, 2025
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
With T3008 we moved from ntpd to chrony. This came with a restructuring of the CLI (mainly moving ntp out of system to services). In addition the definition of a server was made mandatory.
The bug itself manifests at a more crucial point - config migration
The fix is that we will no longer migrate an empty ntp CLI node from the old syntax to the new.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Added a new sample configuration with an empty ntp node that is used in config migration tests.
Checklist: