https: T6734: disable software version reporting

[mwheeler1982]

Change summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

When disabled (default state), server_tokens in nginx are off, HTTP response headers appear like this

< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Mon, 06 Jan 2025 16:56:13 GMT
< Content-Type: text/html
< Content-Length: 162
< Connection: close

When enabled, server_tokens in nginx are on, HTTP response headers appear like this

< HTTP/1.1 301 Moved Permanently
< Server: nginx/1.22.1
< Date: Mon, 06 Jan 2025 16:55:33 GMT
< Content-Type: text/html
< Content-Length: 169
< Connection: close

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) ❌ failed
• CLI Smoketests (interfaces only) ❌ failed
• Config tests ❌ failed
• RAID1 tests 👍 passed
• TPM tests 👍 passed

[c-po]

With default disabled I actually ment this ;)

Suggested change

	server_tokens {{ 'on' if server_version_id is vyos_defined and server_version_id == 'enable' else 'off' }};
	server_tokens 'off';

[mwheeler1982]

Default is off in my submission. What does it hurt to change the default behavior to off (as you prefer), but allow it to be enabled if the user wants it?

[sever-sever]

We do not use bool yes|no, disable|enable, true|false, and so on

• I also prefer to disable the version as in the suggested change.