Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegraf: T6477: adjusting "metric_name_label" indentation in config template #4272

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

ryphon
Copy link
Contributor

@ryphon ryphon commented Jan 2, 2025

Change summary

Adjusting the indentation level of the metric_name_label to be valid inside Loki

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Registered for an account, haven't been approved yet

Related PR(s)

N/A

How to test / Smoketest result

https://github.com/influxdata/telegraf/tree/master/plugins/outputs/loki

See that the config from telegraf is indented, and the j2 is not.

Checklist:

  • I have read the CONTRIBUTING document
  • My commit headlines contain a valid Task id
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 2, 2025


PR title does not match the required format

@c-po c-po merged commit bb46115 into vyos:current Jan 2, 2025
7 of 14 checks passed
Copy link

github-actions bot commented Jan 2, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

@c-po c-po changed the title adjusting "metric_name_label" to correct indentation telegraf: T6477: adjusting "metric_name_label" indentation in config template Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants