-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6671: defer config dependency if scheduled in priority queue #4015
Merged
+180
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jestabro
requested review from
dmbaturin,
sarthurdev,
zdc,
sever-sever,
c-po and
fett0
August 25, 2024 14:35
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
@Mergifyio backport circinus sagitta |
✅ Backports have been created
|
jestabro
force-pushed
the
configdep-prio
branch
from
August 25, 2024 14:40
c54fc1d
to
ff25443
Compare
fett0
approved these changes
Aug 25, 2024
dmbaturin
approved these changes
Aug 25, 2024
jestabro
force-pushed
the
configdep-prio
branch
from
August 25, 2024 22:21
ff25443
to
9ff620c
Compare
Force pushed to move copyright year update to correct commit; no substantive change. |
c-po
approved these changes
Aug 26, 2024
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
If a config dependency is scheduled to run later in the priority queue, defer instead of running immediately from the source script of the dependency. This avoids running a script too early, if it will require the result of an intermediate script in the priority order. For example:
This becomes evident in 1.4 on boot with a suitable configuration, given the presence of the default conntrack modules entries (resolved in 1.5 for new installs; T3275). However, it indicates a general issue, which has a simple resolution in this PR.
Note that this is not apparent in 1.4.0, as there was a earlier pruning mechanism in place for config dependency scripts; that had to be dropped given other issues (T6559; also due to conntrack modules, which provides a useful canary given its low priority) and replaced by a smarter approach in this PR.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest added in PR.
Smoketest result
Checklist: