Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6671: defer config dependency if scheduled in priority queue #4015

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

jestabro
Copy link
Contributor

Change Summary

If a config dependency is scheduled to run later in the priority queue, defer instead of running immediately from the source script of the dependency. This avoids running a script too early, if it will require the result of an intermediate script in the priority order. For example:

            dep
conntrack  ---->  conntrack-sync
   prio \            / prio
      interfaces_bonding

This becomes evident in 1.4 on boot with a suitable configuration, given the presence of the default conntrack modules entries (resolved in 1.5 for new installs; T3275). However, it indicates a general issue, which has a simple resolution in this PR.

Note that this is not apparent in 1.4.0, as there was a earlier pruning mechanism in place for config dependency scripts; that had to be dropped given other issues (T6559; also due to conntrack modules, which provides a useful canary given its low priority) and replaced by a smarter approach in this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest added in PR.

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Aug 25, 2024
@jestabro jestabro requested a review from a team as a code owner August 25, 2024 14:35
Copy link

github-actions bot commented Aug 25, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 25, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

@jestabro
Copy link
Contributor Author

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Aug 25, 2024

backport circinus sagitta

✅ Backports have been created

@jestabro
Copy link
Contributor Author

Force pushed to move copyright year update to correct commit; no substantive change.

@c-po c-po merged commit 42191a8 into vyos:current Aug 26, 2024
13 of 14 checks passed
dmbaturin added a commit that referenced this pull request Aug 26, 2024
T6671: defer config dependency if scheduled in priority queue (backport #4015)
c-po added a commit that referenced this pull request Aug 26, 2024
T6671: defer config dependency if scheduled in priority queue (backport #4015)
@jestabro jestabro deleted the configdep-prio branch September 18, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants