Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op_mode: T6668: Add detailed statistics infomartion about MACsec #4001

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

fett0
Copy link
Contributor

@fett0 fett0 commented Aug 21, 2024

Add detailed statistics infomartion about MACsec interfaces

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

:~$ show interfaces macsec detail
9: macsec1: protect on validate strict sc off sa off encrypt on send_sci on end_station off scb off replay off
    cipher suite: GCM-AES-128, using ICV length 16
    TXSC: 0011223344010001 on SA 0
    stats: OutPktsUntagged InPktsUntagged OutPktsTooLong InPktsNoTag InPktsBadTag InPktsUnknownSCI InPktsNoSCI InPktsOverrun
                         0              0              0           5            0                0           0             0
    stats: OutPktsProtected OutPktsEncrypted OutOctetsProtected OutOctetsEncrypted
                          0               10                  0                808
        0: PN 11, state on, key 00000000000000000000000000000000
    stats: OutPktsProtected OutPktsEncrypted
                          0               10
    RXSC: 0011223344020001, state on
    stats: InOctetsValidated InOctetsDecrypted InPktsUnchecked InPktsDelayed InPktsOK InPktsInvalid InPktsLate InPktsNotValid InPktsNotUsingSA InPktsUnusedSA
                           0               146               0             0        3             0          0              0                0              0
        0: PN 11, state on, key 01000000000000000000000000000000
    stats: InPktsOK InPktsInvalid InPktsNotValid InPktsNotUsingSA InPktsUnusedSA
                  3             0              0                0              0
    offload: off

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@fett0 fett0 requested a review from a team as a code owner August 21, 2024 17:26
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit 4b9318d into vyos:current Aug 22, 2024
12 of 14 checks passed
@c-po
Copy link
Member

c-po commented Aug 22, 2024

@Mergifyio backport sagitta circinus

Copy link
Contributor

mergify bot commented Aug 22, 2024

backport sagitta circinus

✅ Backports have been created

c-po added a commit that referenced this pull request Aug 23, 2024
op_mode: T6668: Add detailed statistics infomartion about MACsec  (backport #4001)
dmbaturin added a commit that referenced this pull request Aug 24, 2024
op_mode: T6668: Add detailed statistics infomartion about MACsec  (backport #4001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants