Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6643: firewall: fix ip address range parsing on firewall rules. (backport #3964) #3968

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 10, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

firewall

Proposed changes

How to test

vyos@T6643# run show config comm | grep firewall
set firewall ipv4 forward filter rule 1 action 'drop'
set firewall ipv4 forward filter rule 1 destination address '192.0.2.100-192.0.2.253'
[edit]
vyos@T6643# sudo nft list chain ip vyos_filter VYOS_FORWARD_filter
table ip vyos_filter {
	chain VYOS_FORWARD_filter {
		type filter hook forward priority filter; policy accept;
		ip daddr 192.0.2.100-192.0.2.253 counter packets 0 bytes 0 drop comment "ipv4-FWD-filter-1"
		counter packets 0 bytes 0 accept comment "FWD-filter default-action accept"
	}
}
[edit]
vyos@T6643# 

Smoketest result

test_firewall.py --> OK
test_policy_route.py --> OK
test_nat.py --> OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3964 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 10, 2024 18:49
@mergify mergify bot added the conflicts label Aug 10, 2024
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, fett0 and nicolas-fort and removed request for a team August 10, 2024 18:49
Copy link

github-actions bot commented Aug 10, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 10, 2024

👍
No issues in unused-imports

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@c-po c-po force-pushed the mergify/bp/circinus/pr-3964 branch from a91196a to fc59359 Compare August 11, 2024 12:54
@c-po c-po self-assigned this Aug 11, 2024
@c-po c-po enabled auto-merge August 11, 2024 12:54
@vyos vyos deleted a comment from mergify bot Aug 11, 2024
@c-po c-po merged commit 33273bc into circinus Aug 11, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3964 branch August 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants