qos: T6638: require interface state existence in verify conditional #3960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add an optional strict requirement of interface state existence to
verify_interface_exists
: this has no effect unless keywordstate_required=True
, as needed in qos.py in case of a late arrivingpppoe
interface.This restores the intended behavior of the conditional in qos.py:
ed63c9d#diff-c3e850625edc3ba2f44020fcda8640d00631b3c67bac756f258b919667b9d67eR306
The obvious question of how to approach re-applying
qos.TrafficShaper.update
when the interface is available (other than providing a warning to the user) is a separate issue which will need to be addressed in a subtask, if not obvious to those more familiar with the subsystem.Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: