Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qos: T6638: require interface state existence in verify conditional #3960

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Aug 8, 2024

Change Summary

Add an optional strict requirement of interface state existence to verify_interface_exists: this has no effect unless keyword state_required=True, as needed in qos.py in case of a late arriving pppoe interface.

This restores the intended behavior of the conditional in qos.py:
ed63c9d#diff-c3e850625edc3ba2f44020fcda8640d00631b3c67bac756f258b919667b9d67eR306

The obvious question of how to approach re-applying qos.TrafficShaper.update when the interface is available (other than providing a warning to the user) is a separate issue which will need to be addressed in a subtask, if not obvious to those more familiar with the subsystem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Aug 8, 2024
@jestabro jestabro requested a review from a team as a code owner August 8, 2024 17:14
Copy link

github-actions bot commented Aug 8, 2024

👍
No issues in PR Title / Commit Title

@c-po
Copy link
Member

c-po commented Aug 8, 2024

@Mergifyio backport sagitta circinus

Copy link
Contributor

mergify bot commented Aug 8, 2024

backport sagitta circinus

✅ Backports have been created

@dmbaturin dmbaturin merged commit be27b89 into vyos:current Aug 9, 2024
16 of 17 checks passed
jestabro added a commit that referenced this pull request Aug 9, 2024
qos: T6638: require interface state existence in verify conditional (backport #3960)
jestabro added a commit that referenced this pull request Aug 9, 2024
qos: T6638: require interface state existence in verify conditional (backport #3960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants