Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketest: T6614: initial support for op-mode command testing #3888

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 27, 2024

Change Summary

We currently lack behind testing OP-mode commands with the smoketest framework.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Smoketests

Smoketest result

[email protected]:~$ /usr/libexec/vyos/tests/smoke/cli/test_op-mode_show.py
test_op_mode_show_version (__main__.TestOPModeShow.test_op_mode_show_version) ... ok
test_op_mode_show_vrf (__main__.TestOPModeShow.test_op_mode_show_vrf) ... ok

----------------------------------------------------------------------
Ran 2 tests in 1.469s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner July 27, 2024 19:15
Copy link

👍
No issues in PR Title / Commit Title

Copy link


warning: Unused import os in smoketest/scripts/cli/test_interfaces_l2tpv3.py:17.

@c-po
Copy link
Member Author

c-po commented Jul 27, 2024

@Mergifyio backport circinus sagitta

@c-po c-po enabled auto-merge July 27, 2024 19:16
Copy link
Contributor

mergify bot commented Jul 27, 2024

backport circinus sagitta

✅ Backports have been created

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

@c-po c-po merged commit d57d84e into vyos:current Jul 28, 2024
13 of 14 checks passed
@c-po c-po deleted the op-mode-smoketest branch July 29, 2024 05:48
c-po added a commit that referenced this pull request Jul 29, 2024
smoketest: T6614: initial support for op-mode command testing (backport #3888)
c-po added a commit that referenced this pull request Jul 29, 2024
smoketest: T6614: initial support for op-mode command testing (backport #3888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants