wireless: T6597: improve hostapd startup and corresponding smoketests (backport #3833) #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
nicolas-fort
12 tasks
|
👍 |
|
👍 |
c-po
approved these changes
Jul 22, 2024
|
Will be rebased after #3847 |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
(cherry picked from commit 11b2731)
(cherry picked from commit f6485f7)
(cherry picked from commit 8bf6687)
This was found during smoketesting as thoase started to repeadingly fail in the last weeks
File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address
self.assertTrue(process_named_running('hostapd'))
AssertionError: None is not true
Digging into this revealed that this is NOT related to the smoketest coding but
to hostapd/systemd instead. With a configured WIFI interface and calling:
"sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short
period caused systemd to report:
"Jul 18 16:15:32 systemd[1]: [email protected]: Deactivated successfully."
According to the internal systemd logic used in our version this is explained by:
/* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not
* undo what has already been enqueued. */
if (unit_stop_pending(UNIT(s)))
allow_restart = false;
if (s->result == SERVICE_SUCCESS)
s->result = f;
if (s->result == SERVICE_SUCCESS) {
unit_log_success(UNIT(s));
end_state = SERVICE_DEAD;`
Where unit_log_success() generates the log message in question.
Improve the restart login in the wireless interface script and an upgrade to
hostapd solved the issue.
(cherry picked from commit a67f49d)
c-po
force-pushed
the
mergify/bp/sagitta/pr-3833
branch
from
3b55d99 to
43e0c4b
Compare
sever-sever
approved these changes
Jul 24, 2024
jestabro
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This was found during smoketesting as thoase started to repeadingly fail in the last weeks
Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling:
sudo systemctl reload-or-restart hostapd@wlan1multiple times in a short period caused systemd to report:
Jul 18 16:15:32 systemd[1]: [email protected]: Deactivated successfully.According to the internal systemd logic used in our version this is explained by:
Where
unit_log_success()generates the log message in question.Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
wireless
How to test
Smoketests
Smoketest result
Checklist:
This is an automatic backport of pull request #3833 done by [Mergify](https://mergify.com).