Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6594: Add missed pppd_compat module #3832

Merged
merged 4 commits into from
Jul 22, 2024
Merged

T6594: Add missed pppd_compat module #3832

merged 4 commits into from
Jul 22, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Add missed pppd_compat module, used for accel-ppp daemons to call external scripts
We have extended scripts in CLI, but they do not call because the module is not loaded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

IPoE, SSTP, PPTP, L2TP-server

Proposed changes

How to test

set service ipoe-server authentication mode 'noauth'
set service ipoe-server client-ip-pool ONE range '100.64.0.1-100.64.0.10'
set service ipoe-server client-ipv6-pool POOL-v6 delegate 2001:db8:8003::/48 delegation-prefix '56'
set service ipoe-server client-ipv6-pool POOL-v6 prefix 2001:db8::/64
set service ipoe-server default-ipv6-pool 'POOL-v6'
set service ipoe-server default-pool 'ONE'
set service ipoe-server extended-scripts on-up '/config/scripts/accel-pppd/on-up-flush.sh'
set service ipoe-server gateway-address '100.64.0.14/28'
set service ipoe-server interface eth1 network 'shared'
set service ipoe-server name-server '192.168.122.14'

Before the fix, after a subscriber connection (ipoe) the script on-ip-flush.sh is not executed

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link


Commit title 'IPoE-server: add missed pppd_compat module' does not match the required format!. Valid title example: T99999: make IPsec secure

Copy link

👍
No issues in unused-imports

@c-po c-po enabled auto-merge July 19, 2024 13:12
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed

@c-po c-po merged commit e64322c into vyos:current Jul 22, 2024
12 of 14 checks passed
@sever-sever
Copy link
Member Author

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Jul 23, 2024

backport circinus sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jul 23, 2024
T6594: Add missed pppd_compat module (backport #3832)
c-po added a commit that referenced this pull request Jul 25, 2024
T6594: Add missed pppd_compat module (backport #3832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants