-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6594: Add missed pppd_compat module #3832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sever-sever
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
fett0
July 19, 2024 12:23
❌ |
👍 |
c-po
approved these changes
Jul 19, 2024
CI integration ❌ failed! Details
|
dmbaturin
approved these changes
Jul 22, 2024
@Mergifyio backport circinus sagitta |
✅ Backports have been created
|
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add missed
pppd_compat
module, used for accel-ppp daemons to call external scriptsWe have extended scripts in CLI, but they do not call because the module is not loaded.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
IPoE, SSTP, PPTP, L2TP-server
Proposed changes
How to test
Before the fix, after a subscriber connection (ipoe) the script
on-ip-flush.sh
is not executedSmoketest result
Checklist: