Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: T6591: deprecate OpenVPN server net30 topology (backport #3825) #3829

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 18, 2024

Change Summary

Set the default topology to subnet for new configs, add a deprecation warning, and insert net30 in old configs explicitly for compatibility.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): default change, deprecation.

Related Task(s)

Related PR(s)

Component(s) name

OpenVPN

Proposed changes

The net30 topology is:

  • only there because it was the default in OpenVPN, but even then it was just for compatibility reasons, not because it's good;
  • bad for Windows clients, they don't work with it;
  • deprecated in OpenVPN and may eventually be removed.

We should set the new default to subnet and mark net30 as deprecated. But some people may rely on the net30 behavior, so we'll use a migration script to inject the old default into old configs explicitly.

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3825 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 18, 2024 18:58
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and nicolas-fort and removed request for a team July 18, 2024 18:58
Copy link

👍
No issues in PR Title / Commit Title

Copy link

👍
No issues in unused-imports

@c-po c-po merged commit 623d773 into circinus Jul 19, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3825 branch July 19, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants