Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6527: add legacy Vyatta interpreter files still in use #3745

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 30, 2024

Change Summary

Remove legacy packages from ISO build.

  • vyatta-cfg-system
  • vyatta-op

Are no longer required and migrated to vyos-1y. vyatta-wanloadbalance, vyatta-bash and vyatta-cfg are now a direct dependency of vyos-1x, so everything in one place.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Smoketest result

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add license headers with attribution to Vyatta at least to all non-trivial files. Maybe even just add them to all files, even allowed-op and similar, just to make it clear where they came from and who the real author is — it's unlikely that we'll get into legal trouble for not attributing trivial files, but I think it's a good thing to do.

We can also clean files from legacy stuff like serial WAN, since it was never supported in VyOS anyway.

@c-po
Copy link
Member Author

c-po commented Jun 30, 2024

I think we should add license headers with attribution to Vyatta at least to all non-trivial files. Maybe even just add them to all files, even allowed-op and similar, just to make it clear where they came from and who the real author is — it's unlikely that we'll get into legal trouble for not attributing trivial files, but I think it's a good thing to do.

We can also clean files from legacy stuff like serial WAN, since it was never supported in VyOS anyway.

All requested changes addressed.

@c-po c-po requested a review from dmbaturin June 30, 2024 20:11
Copy link

👍 VyOS CLI smoketests finished successfully!

@dmbaturin dmbaturin merged commit b1d74fe into vyos:current Jul 2, 2024
12 checks passed
@c-po c-po deleted the no-legacy branch July 2, 2024 16:12
@c-po
Copy link
Member Author

c-po commented Jul 3, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Jul 3, 2024

backport circinus

✅ Backports have been created

c-po added a commit that referenced this pull request Jul 4, 2024
T6527: add legacy Vyatta interpreter files still in use (backport #3745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants