Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T5633, T6465: fix error when op cmd interrupted, updates some system call syntax (backport #3731) #3734

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 28, 2024

Change Summary

Replaces previous PR which I closed by accident: #3700

Summary:
Add exception catching for broken pipe error to exit gracefully when user stops program output. Resolves T5633: Bug 1 and 3

Corrects syntax for invoked "show ipv6 route bgp" command

Updates syntax for invoked show system image version / show system image storage to new CLI syntax

Note: Bug 2 identified in T5633 is non-breaking but has not been solved in this PR. I've narrowed the issue down to the underlying vyatta-op-cmd-wrapper shell code. I'm proposing to open a new Maniphest ticket specifically on this bug and close T5633 when PR is merged that way it's separated from this work and still visible as a bug to be fixed in the future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5633 bugs 1 and 3
https://vyos.dev/T6465

Related PR(s)

Component(s) name

Proposed changes

See above for changes.

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3731 done by [Mergify](https://mergify.com).

…lls to new cli syntax (#3731)

(cherry picked from commit a095a3c)
@mergify mergify bot requested a review from a team as a code owner June 28, 2024 07:55
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and nicolas-fort and removed request for a team June 28, 2024 07:55
Copy link


PR title 'op-mode: T5633, T6465: fix error when op cmd interrupted, updates some system call syntax (backport #3731)' does not match the required format!. Valid title example: T99999: make IPsec secure

@c-po c-po merged commit 7a31293 into circinus Jun 28, 2024
5 of 6 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3731 branch June 28, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants