Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6497: CGNAT refactoring delete conntrack entries (backport #3699) #3732

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 27, 2024

Change Summary

Refactoring of the deleting conntrack entries.
Use native ipaddress.summary function
Delete only required entries by internal network

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

cgnat

Proposed changes

How to test

Smoketest result

vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_cgnat.py
test_cgnat (__main__.TestCGNAT.test_cgnat) ... 
Rule must be defined!


Rule must be defined!


External pool "fake-pool" does not exist!

ok
test_cgnat_sequence (__main__.TestCGNAT.test_cgnat_sequence) ... ok

----------------------------------------------------------------------
Ran 2 tests in 24.286s

OK
vyos@r4:~$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3699 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner June 27, 2024 19:10
@mergify mergify bot added the conflicts label Jun 27, 2024
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and nicolas-fort and removed request for a team June 27, 2024 19:10
Copy link

github-actions bot commented Jun 27, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po added the circinus label Jun 27, 2024
@sever-sever sever-sever force-pushed the mergify/bp/circinus/pr-3699 branch from 4e042e4 to 62e89ec Compare June 28, 2024 08:44
@vyos vyos deleted a comment from mergify bot Jun 28, 2024
@sever-sever sever-sever merged commit a975db9 into circinus Jul 2, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3699 branch July 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants