Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6477: Add telegraf loki output plugin #3720

Merged
merged 1 commit into from
Jun 28, 2024
Merged

T6477: Add telegraf loki output plugin #3720

merged 1 commit into from
Jun 28, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Add Loki plugin to telegraf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

telegraf

Proposed changes

How to test

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever sever-sever requested a review from a team as a code owner June 25, 2024 10:09
@sever-sever
Copy link
Member Author

@Mergifyio backport circinus sagitta

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024 •
edited
Loading

backport circinus sagitta

✅ Backports have been created

@c-po
Copy link
Member

c-po commented Jun 27, 2024

Should there probably a verify() check that if username is specified, so must be password and vice versa?

@sever-sever
Copy link
Member Author

Should there probably a verify() check that if username is specified, so must be password and vice versa?

Done!

c-po
c-po requested changes Jun 27, 2024
View reviewed changes
smoketest/scripts/cli/test_service_monitoring_telegraf.py
port = '3100'

self.cli_set(base_path + ['loki', 'url', loki_url])
self.cli_set(base_path + ['loki', 'port', port])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test code for username and password and also check if the exception is present when only username is specified but no password

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@sever-sever
T6477: Add telegraf loki output plugin
3365eb7 
Add Loki plugin to telegraf

set service monitoring telegraf loki url xxx
@sever-sever sever-sever requested a review from c-po June 28, 2024 10:53
@c-po c-po merged commit f36271b into vyos:current Jun 28, 2024
11 of 12 checks passed
This was referenced Jun 28, 2024
Merged
Merged
dmbaturin added a commit that referenced this pull request Jun 28, 2024
@dmbaturin
Merge pull request #3739 from vyos/mergify/bp/circinus/pr-3720
551dfa5 
T6477: Add telegraf loki output plugin (backport #3720)
@github-actions GitHub Actions
Copy link

❌ VyOS CLI smoketests failed!

@nvollmar nvollmar mentioned this pull request Jul 1, 2024
Merged
1 task
c-po added a commit that referenced this pull request Jul 1, 2024
@c-po
Merge pull request #3738 from vyos/mergify/bp/sagitta/pr-3720
f61bd91 
T6477: Add telegraf loki output plugin (backport #3720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@sever-sever sever-sever

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sever-sever @c-po @dmbaturin