Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6313: Add "NAT" to "generate" command for rule resequence #3715

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

HollyGurza
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

generate firewall rule-resequence
generate firewall rule-resequence start 200
generate firewall rule-resequence start 200 step 100

generate nat rule-resequence
generate nat rule-resequence start 200
generate nat rule-resequence start 200 step 100

generate nat64 rule-resequence
generate nat64 rule-resequence start 200
generate nat64 rule-resequence start 200 step 100

generate nat66 rule-resequence
generate nat66 rule-resequence start 200
generate nat66 rule-resequence start 200 step 100

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

❌ VyOS CLI smoketests failed!

@c-po c-po merged commit 7d91768 into vyos:current Jun 27, 2024
11 of 12 checks passed
@sever-sever
Copy link
Member

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Jul 30, 2024

backport circinus sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jul 31, 2024
T6313: Add "NAT" to "generate" command for rule resequence (backport #3715)
fett0 added a commit that referenced this pull request Jul 31, 2024
T6313: Add "NAT" to "generate" command for rule resequence (backport #3715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants