Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pppoe-server: T6234: fix permissions on migration script #3402

Merged
merged 1 commit into from
May 3, 2024
Merged

pppoe-server: T6234: fix permissions on migration script #3402

merged 1 commit into from
May 3, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented May 2, 2024

Change Summary

Fix file permissions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po changed the base branch from current to sagitta May 2, 2024 18:49
@c-po c-po added sagitta VyOS 1.4 LTS and removed current labels May 2, 2024
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc and jestabro and removed request for a team May 2, 2024 19:09
@jestabro jestabro merged commit 1ff4ca4 into vyos:sagitta May 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @jestabro @sever-sever