haproxy: T6179: fix rule generation

[nvollmar]

Change Summary

Fix config generation for different combinations of set-backend/redirect-location

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T6179

Related PR(s)

None

Component(s) name

load-balancing

Proposed changes

path acl rules (and domain_name for that matter) can be used with both set-backend or redirect-location
(https://www.haproxy.com/blog/path-based-routing-with-haproxy has an example with set-backend)

How to test

set load-balancing reverse-proxy service foo port '4443'
set load-balancing reverse-proxy service foo rule 10 set backend 'bk01'
set load-balancing reverse-proxy service foo rule 10 url-path end '/local'
set load-balancing reverse-proxy backend bk01 server s1 address '192.0.2.1'
set load-balancing reverse-proxy backend bk01 server s1 port '4443'

should yield the frontend config config:

# Frontend
frontend foo
    bind :::4443 v4v6  
    # rule 10
    acl 10 path -i -m end /local
    use_backend bk01 if 10

Smoketest result

$ /usr/libexec/vyos/tests/smoke/cli/test_load-balancing_reverse-proxy.py
test_01_lb_reverse_proxy_domain (__main__.TestLoadBalancingReverseProxy.test_01_lb_reverse_proxy_domain) ... ok
test_02_lb_reverse_proxy_cert_not_exists (__main__.TestLoadBalancingReverseProxy.test_02_lb_reverse_proxy_cert_not_exists) ... 
PKI does not contain any certificates!


Certificate "cert" not found in configuration!

ok
test_03_lb_reverse_proxy_ca_not_exists (__main__.TestLoadBalancingReverseProxy.test_03_lb_reverse_proxy_ca_not_exists) ... ok
test_04_lb_reverse_proxy_backend_ssl_no_verify (__main__.TestLoadBalancingReverseProxy.test_04_lb_reverse_proxy_backend_ssl_no_verify) ... 
backend bk-01 cannot have both ssl options no-verify and ca-certificate
set!

ok
test_05_lb_reverse_proxy_backend_http_check (__main__.TestLoadBalancingReverseProxy.test_05_lb_reverse_proxy_backend_http_check) ... ok
test_06_lb_reverse_proxy_tcp_mode (__main__.TestLoadBalancingReverseProxy.test_06_lb_reverse_proxy_tcp_mode) ... ok

----------------------------------------------------------------------
Ran 6 tests in 86.712s

OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[sever-sever]

Thanks for fix

[c-po]

@Mergifyio backport sagitta

[mergify]

backport Sagitta

❌ No backport have been created

• Backport to branch Sagitta failed

GitHub error: Branch not found

[mergify]

backport sagitta

✅ Backports have been created

• #3383 haproxy: T6179: fix rule generation (backport #3382) has been created for branch sagitta