Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5660: Remove redundant calls to config dependency scripts #3373

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

jestabro
Copy link
Contributor

Change Summary

NOTE: this requires the companion PR for vyatta-cfg: vyos/vyatta-cfg#78

This is a combined backport of those commits related to pruning redundancies in the list of config dependencies.

Tested with testd, smoketests running under vyos-configd.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyatta-cfg#78

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Apr 29, 2024
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 29, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team April 29, 2024 00:45
@dmbaturin dmbaturin merged commit c1507d6 into vyos:sagitta Apr 29, 2024
5 checks passed
@jestabro jestabro deleted the sagitta-configdep-redundancy branch July 29, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants