T6263: Groups 224.0.0.0/24 are reserved and cannot be joined (backport #3363)

[mergify]

Change Summary

The join addresses within the multicast group 224.0.0.0/24 are reserved and cannot be joined

FRR

r4(config)# interface eth2
r4(config-if)# ip igmp join 224.0.0.0 224.0.0.10
% Configuration failed.

Error type: validation
Error description: Groups within 224.0.0.0/24 are reserved and cannot be joined
r4(config-if)#

https://github.com/FRRouting/frr/blob/3bb7b497911124c9b69210668f5ca05ec9e8136c/pimd/pim_nb_config.c#L2842-L2845

Add verify check

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T6263

Related PR(s)

Component(s) name

pim, igmp

Proposed changes

How to test

Use join address in the network 224.0.0.0/24 (expected error as this network is reserved)

set protocols pim interface eth2 igmp join 224.0.0.0 source-address 224.0.0.10
commit

Before the fix:

[10619|mgmtd] sending configuration [10620|zebra] sending configuration
[10621|ripd] sending configuration [10622|ripngd] sending configuration
[10623|ospfd] sending configuration [10624|ospf6d] sending configuration
[10625|ldpd] sending configuration [10626|bgpd] sending configuration
[10627|isisd] sending configuration [10628|pimd] sending configuration
[10631|babeld] sending configuration [10637|bfdd] sending configuration
[10634|watchfrr] sending configuration [10636|staticd] sending
configuration [10619|mgmtd] done [10620|zebra] done Waiting for children
to finish applying config... [10627|isisd] done [10621|ripd] done
[10640|pim6d] sending configuration [10636|staticd] done [10622|ripngd]
done [10625|ldpd] done [10626|bgpd] done [10623|ospfd] done %
Configuration failed.  Error type: validation Error description: Groups
within 224.0.0.0/24 are reserved and cannot be joined line 6: Failure to
communicate[13] to pimd, line:  ip igmp join 224.0.0.0 224.0.0.10
[10634|watchfrr] done [10624|ospf6d] done [10637|bfdd] done
[10631|babeld] done [10628|pimd] Configuration file[/etc/frr/frr.conf]
processing failure: 13 [10640|pim6d] done [10644|mgmtd] sending
configuration [10645|zebra] sending configuration [10646|ripd] sending
configuration [10647|ripngd] sending configuration [10648|ospfd] sending
configuration [10649|ospf6d] sending configuration [10650|ldpd] sending
configuration [10651|bgpd] sending configuration [10653|pimd] sending
configuration [10652|isisd] sending configuration [10656|babeld] sending
configuration [10661|staticd] sending configuration [10662|bfdd] sending
configuration [10659|watchfrr] sending configuration [10649|ospf6d] done
Waiting for children to finish applying config... [10665|pim6d] sending
configuration [10661|staticd] done [10644|mgmtd] done [10650|ldpd] done
[10651|bgpd] done [10646|ripd] done [10652|isisd] done % Configuration
failed.  Error type: validation Error description: Groups within
224.0.0.0/24 are reserved and cannot be joined line 6: Failure to
communicate[13] to pimd, line:  ip igmp join 224.0.0.0 224.0.0.10
[10647|ripngd] done [10648|ospfd] done [10656|babeld] done [10665|pim6d]
done [10645|zebra] done [10659|watchfrr] done [10662|bfdd] done %
Configuration failed.  Error type: validation Error description: Groups
within 224.0.0.0/24 are reserved and cannot be joined line 18: Failure
to communicate[13] to pimd, line:  ip igmp join 224.0.0.0 224.0.0.10
[10653|pimd] Configuration file[/etc/frr/frr.conf] processing failure:
13

After the fix:

vyos@r4# set protocols pim interface eth2 igmp join 224.0.0.0 source-address 224.0.0.10
[edit]
vyos@r4# commit
[ protocols pim ]
Groups within 224.0.0.0/24 are reserved and cannot be joined!

[[protocols pim]] failed
Commit failed
[edit]
vyos@r4# 

Smoketest result

vyos@r4:~$ /usr/libexec/vyos/tests/smoke/cli/test_protocols_pim.py
test_01_pim_basic (__main__.TestProtocolsPIM.test_01_pim_basic) ... ok
test_02_pim_advanced (__main__.TestProtocolsPIM.test_02_pim_advanced) ... ok
test_03_pim_igmp_proxy (__main__.TestProtocolsPIM.test_03_pim_igmp_proxy) ... ok
test_04_igmp (__main__.TestProtocolsPIM.test_04_igmp) ... ok

----------------------------------------------------------------------
Ran 4 tests in 55.848s

OK
vyos@r4:~$ 

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

---

This is an automatic backport of pull request #3363 done by [Mergify](https://mergify.com).