T6258: Add sysctl base-reachable-time for IPv6 (backport #3361) #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Add abiilty to change `base_reachable_time_ms` option
/proc/sys/net/ipv6/neigh/{ifname}/base_reachable_time_ms
(cherry picked from commit 0bf4b57)
12 tasks
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
and removed request for
a team
dmbaturin
approved these changes
Apr 25, 2024
sever-sever
approved these changes
Apr 25, 2024
c-po
reviewed
Apr 25, 2024
| @@ -1656,6 +1677,11 @@ def update(self, config): | |||
| for addr in tmp: | |||
| self.add_ipv6_eui64_address(addr) | |||
|
|
|||
| # Configure IPv6 base time in milliseconds - has default value | |||
| tmp = dict_search('ipv6.base_reachable_time', config) | |||
| value = tmp if (tmp != None) else '30' | |||
There was a problem hiding this comment.
The else path is not required as there is an interface default value. Please drop it in a subsequent commit
c-po
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add ability to change
base_reachable_time_msoption/proc/sys/net/ipv6/neigh/{ifname}/base_reachable_time_msTypes of changes
Related Task(s)
Related PR(s)
Component(s) name
sysctl
Proposed changes
How to test
Configure the option and check that the value is applied:
Smoketest result
Checklist:
This is an automatic backport of pull request #3361 done by [Mergify](https://mergify.com).