Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5858: Fix op-mode format for show conntrack statistics (backport #3280) #3282

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 9, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

conntrack

Proposed changes

How to test

Before the fix, the output looks bad formated:

vyos@r15-left:~$ show conntrack statistics 
                CPU          Found     Invalid          Insert    Insert fail    Drop       Early drop        Errors    Search restart
-----  -------  -----------  --------  ---------------  --------  -------------  ---------  ----------------  --------  ----------------
cpu=0  found=0  invalid=174  insert=0  insert_failed=1  drop=1    early_drop=0   error=1    search_restart=0  (null)=2  (null)=0
cpu=1  found=0  invalid=73   insert=0  insert_failed=0  drop=0    early_drop=0   error=126  search_restart=0  (null)=1  (null)=0
vyos@r15-left:~$ 

After the fix:

vyos@r15-left:~$ show conntrack statistics 
CPU    Found    Invalid    Insert    Insert fail    Drop    Early drop    Errors    Search restart
-----  -------  ---------  --------  -------------  ------  ------------  --------  ----------------  --  --
0      0        174        0         1              1       0             1         0                 2   0
1      0        73         0         0              0       0             126       0                 1   0
vyos@r15-left:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3280 done by [Mergify](https://mergify.com).

@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 9, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 9, 2024 14:58
@c-po c-po merged commit 8025778 into sagitta Apr 9, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3280 branch April 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants