Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6207: restore ability to copy config.boot.default on image install #3278

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Apr 8, 2024

Change Summary

NOTE: this requires the companion PR vyos/vyos-build#551 to adjust the test script for added prompt.

The option to use config.boot.default was unfortunately dropped during development of the revised image-tools; this is a problem, for example, for EVE-NG installs:
https://www.eve-ng.net/index.php/documentation/howtos/howto-add-vyos-vyatta/

Restore option.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-build#551

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Apr 8, 2024
@vyosbot vyosbot requested a review from a team April 8, 2024 04:07
@vyosbot vyosbot requested review from dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team April 8, 2024 04:07
@c-po
Copy link
Member

c-po commented Apr 8, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit 41abc30 into vyos:current Apr 8, 2024
9 checks passed
dmbaturin added a commit that referenced this pull request Apr 8, 2024
T6207: restore ability to copy config.boot.default on image install (backport #3278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants