Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: T6208: rename "cap-add" CLI node to "capability" (backport #3269) #3271

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 7, 2024

Change Summary

Containers have the ability to add Linux system capabilities to them, this is done using the set container name <name> cap-add command.

The CLI node sounds off and rather should be set container name <name> capability instead as we use and pass a capability to a container and not add/invent new ones.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

container

Proposed changes

CLI migration

How to test

Updated smoketests

set container name c01 allow-host-networks
set container name c01 capability 'net-bind-service'
set container name c01 capability 'net-raw'
set container name c01 image 'busybox:stable'
set container name c02 allow-host-networks
set container name c02 capability 'sys-time'
set container name c02 image 'busybox:stable'

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3269 done by [Mergify](https://mergify.com).

Containers have the ability to add Linux system capabilities to them, this is
done using the "set container name <name> cap-add" command.

The CLI node sounds off and rather should be "set container name <name>
capability" instead as we use and pass a capability to a container and not
add/invent new ones.

(cherry picked from commit b30faa4)
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 7, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 7, 2024 00:03
@c-po c-po merged commit c5cda09 into sagitta Apr 7, 2024
5 checks passed
@c-po c-po deleted the mergify/bp/sagitta/pr-3269 branch April 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants