Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6199: remove unused Python imports from migration scripts (backport #3260) #3261

Merged
merged 2 commits into from
Apr 6, 2024
Merged

T6199: remove unused Python imports from migration scripts (backport #3260) #3261

merged 2 commits into from
Apr 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 6, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #3260 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Apr 6, 2024
@mergify mergify bot mentioned this pull request Apr 6, 2024
Merged
12 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 6, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 6, 2024 08:49
c-po added 2 commits April 6, 2024 10:58
@c-po
T6199: remove unused Python imports from migration scripts
289c5ea 
(cherry picked from commit 489e6fa)

# Conflicts:
#	src/migration-scripts/dhcp-server/9-to-10
#	src/migration-scripts/dhcpv6-server/3-to-4
@c-po
Debian: T6199: add pylint do list of build dependencies
98a2583 
(cherry picked from commit 7178630)
@c-po c-po force-pushed the mergify/bp/sagitta/pr-3260 branch from 42bf9e6 to 98a2583 Compare April 6, 2024 09:00
@vyos vyos deleted a comment from mergify bot Apr 6, 2024
@c-po c-po added backport and removed conflicts labels Apr 6, 2024
@dmbaturin dmbaturin merged commit f072126 into sagitta Apr 6, 2024
2 of 3 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3260 branch April 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
backport sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmbaturin @c-po