Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6199: spring cleaning - drop unused Python imports (backport #3240) #3241

Merged
merged 5 commits into from
Apr 4, 2024
Merged

T6199: spring cleaning - drop unused Python imports (backport #3240) #3241

merged 5 commits into from
Apr 4, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 3, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 4 commits April 3, 2024 21:01
@c-po
T6199: drop unused sphinx documentation folder
9305f61 
(cherry picked from commit 86b6328)
@c-po
T6199: replace netifaces.interfaces() with common custom helpers
86f793f 
* Use interface_exists() outside of verify()
* Use verify_interface_exists() in verify() to drop common error message

(cherry picked from commit 4c7c168)
@c-po
T6199: drop unused Python imports
3ea68d6 
found using "git ls-files *.py | xargs pylint | grep W0611"

(cherry picked from commit 274b2da)
@c-po
GitHub: add action to check for unused imports
8c21030 
(cherry picked from commit 74198e6)
@c-po c-po changed the base branch from current to sagitta April 3, 2024 19:13
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 3, 2024 19:13
@c-po c-po force-pushed the spring-cleaning-sagitta branch from 5b9da31 to ca84e68 Compare April 3, 2024 19:17
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 3, 2024
@c-po c-po added backport and removed current labels Apr 3, 2024
sever-sever
sever-sever approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rely on pylint

@dmbaturin dmbaturin merged commit 7f077a0 into vyos:sagitta Apr 4, 2024
2 of 3 checks passed
@c-po c-po deleted the spring-cleaning-sagitta branch April 7, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
backport sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @sever-sever