ddclient: T5791: Keep ddclient.service in foreground

Since the distributed ddclient.service is of type 'exec' now, avoid using process forking and let systemd manage the process directly.
vyos · Jan 4, 2025 · fd2d452 · fd2d452
1 parent 9dae22e
commit fd2d452
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/data/templates/dns-dynamic/ddclient.conf.j2 b/data/templates/dns-dynamic/ddclient.conf.j2
@@ -22,9 +22,9 @@ if{{ ipv }}={{ address }}, \
 {% endmacro %}
 ### Autogenerated by service_dns_dynamic.py ###
 daemon={{ interval }}
+foreground=yes
 syslog=yes
 ssl=yes
-pid={{ config_file | replace('.conf', '.pid') }}
 cache={{ config_file | replace('.conf', '.cache') }}
 {# ddclient default (web=dyndns) doesn't support ssl and results in process lockup #}
 web=googledomains

diff --git a/data/templates/dns-dynamic/override.conf.j2 b/data/templates/dns-dynamic/override.conf.j2
@@ -4,7 +4,6 @@ ConditionPathExists={{ config_file }}
 After=vyos-router.service
 
 [Service]
-PIDFile={{ config_file | replace('.conf', '.pid') }}
 EnvironmentFile=
 ExecStart=
 ExecStart={{ vrf_command }}/usr/bin/ddclient -file {{ config_file }}