nat: T6365: use string startswith() over [0] index access

vyos · May 22, 2024 · 3870247 · 3870247
1 parent 03eae30
commit 3870247
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/conf_mode/nat.py b/src/conf_mode/nat.py
@@ -151,7 +151,7 @@ def verify(nat):
                 elif 'name' in config['outbound_interface']:
                     interface_name = config['outbound_interface']['name']
                     if interface_name not in 'any':
-                        if interface_name[0] == '!':
+                        if interface_name.startswith('!'):
                             interface_name = interface_name[1:]
                         if interface_name not in interfaces():
                             Warning(f'NAT interface "{interface_name}" for source NAT rule "{rule}" does not exist!')
@@ -188,7 +188,7 @@ def verify(nat):
                 elif 'name' in config['inbound_interface']:
                     interface_name = config['inbound_interface']['name']
                     if interface_name not in 'any':
-                        if interface_name[0] == '!':
+                        if interface_name.startswith('!'):
                             interface_name = interface_name[1:]
                         if interface_name not in interfaces():
                             Warning(f'NAT interface "{interface_name}" for destination NAT rule "{rule}" does not exist!')